Testing m68k changes on AmigaOS and Linux/m68k

[Bernardo Innocenti]

Gunther Nikl wrote:

>>Since I can only test on ColdFire targets, would you mind doing a
>>bootstrap on Linux/m68k and/or AmigaOS?
> 
>   I maintain my patches on a cross-setup by building a cross-compiler.
>   That cross-compiler is then used to build a "native" compiler for my
>   target. I don't boostrap on the target because thats much to slow for
>   my taste ;-(

I guess building on my old Amiga 4000 with its 25MHz 68040 would take a
couple of days :-)

>   Building the cross-compiler revealed two errors in m68k.c. The patch is
>   attached. Using the cross-compiler to built the native compiler revealed
>   two bugs (?) in gcc/Makefile[.in].

You're probably one of the few people who exercise canadian cross
builds :-)


>   I changed the Makefile and was able
>   to build the native compiler but I don't know whether my changes to the
>   Makefile are correct. The cross-compiler to AmigaOS seems to work
>   correctly (modulo the open issues regarding small-data). I goint to test
>   the coss-built native compiler tonight.

I see you're using the MIT syntax on the Amiga. Some guy told me the
GeekGadgets port of GCC used it. Have you ever tried defining MOTOROLA?
If you're luckly, it should work out of the box.

I'm asking because I still have a (not so hidden) agenda for obsoleting
the MIT syntax some day...

Your patch looks fine to me, but it doesn't fall under the "obvious patch"
definition (it changes code).

Richard, is it OK to apply?

> --cut--
> 2003-10-13  Gunther Nikl  <gni@gecko.de>
> 
> 	* config/m68k/m68k.c (m68k_output_function_prologue): Fix usage of
> 	current_frame at two places (one type and one missing)
> 
> --- m68k.c.orig	Mon Oct 13 11:35:20 2003
> +++ m68k.c	Mon Oct 13 14:48:23 2003
> @@ -623,7 +623,7 @@
>  #ifdef MOTOROLA
>  	  asm_fprintf (stream, "\tfmovm %I0x%x,-(%Rsp)\n", current_frame.fpu_mask);
>  #else
> -	  asm_fprintf (stream, "\tfmovem %I0x%x,%Rsp@-\n", current_frmae.fpu_mask);
> +	  asm_fprintf (stream, "\tfmovem %I0x%x,%Rsp@-\n", current_frame.fpu_mask);
>  #endif
>  	  if (dwarf2out_do_frame ())
>  	    {
> @@ -934,7 +934,7 @@
>  #else
>                asm_fprintf (stream, "\tmoveml %s@(-%wd),%I0x%x\n",
>                             reg_names[FRAME_POINTER_REGNUM],
> -                           offset + fsize,
> +                           current_frame.offset + fsize,
>  			   current_frame.reg_mask);
>  #endif
>  	    }
> --cut--

-- 
  // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/

Please don't send Word attachments - http://www.gnu.org/philosophy/no-word-attachments.html