PATCH: "make check" is broken in binutils

H. J. Lu hjl@lucon.org
Tue May 20 16:29:00 GMT 2003


On Tue, May 20, 2003 at 08:53:40AM -0700, H. J. Lu wrote:
> This patch:
> 
> 2003-05-19  Nathanael Nerode  <neroden@gcc.gnu.org>
>  
>         * configure.in: Switch more things to use maybe dependencies.
>         * Makefile.tpl: Switch more things to use maybe dependencies.
>         Factor out common code from autogen IF statements.
>         * configure: Regenerate.
>         * Makefile.in: Regenerate.
>  
> breaks "make check" in binutils. I got
> 
> make[3]: *** No rule to make target `maybe-check-gcc', needed by `do-che
> ck'.
> 
> Could you please fix it?
> 
> Thanks.

I am testing this patch.


H.J.
-------------- next part --------------
2003-05-20  H.J. Lu <hongjiu.lu@intel.com>

	* Makefile.tpl (do-check): Change maybe-check-gcc to
	@maybe_check_gcc@.
	* Makefile.in: Regenerated.

	* configure.in (maybe_check_gcc): New and substitute. Defined
	as maybe-check-gcc for gcc.
	* configure: Regenerated.

--- binutils/Makefile.tpl.check	2003-05-20 08:38:03.000000000 -0700
+++ binutils/Makefile.tpl	2003-05-20 09:11:47.000000000 -0700
@@ -743,7 +743,7 @@ check:
 	$(MAKE) do-check NOTPARALLEL=parallel-ok
 
 # Only include modules actually being configured and built.
-do-check: maybe-check-gcc [+
+do-check: @maybe_check_gcc@ [+
   FOR host_modules +] \
     maybe-check-[+module+][+
   ENDFOR host_modules +][+
--- binutils/configure.in.check	2003-05-20 08:38:03.000000000 -0700
+++ binutils/configure.in	2003-05-20 09:11:27.000000000 -0700
@@ -100,6 +100,9 @@ else
     esac
   fi
 fi
+if test x${gcc_version_trigger} != x; then
+  maybe_check_gcc="maybe-check-gcc"
+fi
 
 ### To add a new directory to the tree, first choose whether it is a target
 ### or a host dependent tool.  Then put it into the appropriate list
@@ -1974,6 +1977,7 @@ AC_SUBST(BUILD_PREFIX)
 AC_SUBST(BUILD_PREFIX_1)
 AC_SUBST(configlinks)
 AC_SUBST(gcc_version_trigger)
+AC_SUBST(maybe_check_gcc)
 AC_SUBST(gcc_version)
 AC_SUBST(tooldir)
 AC_SUBST(build_tooldir)


More information about the Gcc mailing list