PATCH (head): -Wunused-static-variable
Kaveh R. Ghazi
ghazi@caip.rutgers.edu
Fri May 2 13:03:00 GMT 2003
> In reference to the message thread starting at
> http://gcc.gnu.org/ml/gcc/2003-04/msg01494.html
>
> how about the following patch. This is against the head, but I can
> easily redo this on the 3.3 branch if that is desired and someone
> can take care of the merging back to the head.
>
> 2003-05-01 Kean Johnston <jkj@sco.com>
>
> * c-opts.c (COMMAND_LINE_OPTIONS): Add -Wunused-static-variable
> for finer grained warning control.
> * doc/invoke.texi: Document it.
> * flags.h: Declare warn_unused_static_variable.
> * toplev.c (W_options): Add it.
> (check_global_declarations): Use it.
I'd prefer this warning was controlled by -W as suggested elsewhere.
We already control warning about unused parameter variables this way,
so there is precedent for this. E.g. try compiling this snippet with
"-Wall" and again with "-W -Wall".
void foo(int a)
{
}
You'll only get the warning about unused `a' with -W added.
We should do the same with this controversial "unused" warning.
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu
More information about the Gcc
mailing list