i386-cmov1.c broken

Daniel Jacobowitz drow@mvista.com
Sat Jun 7 18:49:00 GMT 2003


On Sat, Jun 07, 2003 at 07:36:29PM +0200, Jan Hubicka wrote:
> > > > 
> > > > In auditing the GCC tests, I think that gcc.dg/i386-cmov1.c is passing
> > > > "by accident".
> > > > 
> > > > In particular, this test seems to be trying to verify that the "sar"
> > > > instruction is being used with "magic_namec" by scanning the assembly
> > > > file.
> > > > 
> > > > However, that's not actually happening.
> > > > 
> > > > The scan-assembler test:
> > > > 
> > > >   /* { dg-final { scan-assembler "sar.*magic_namec" } } */
> > > > 
> > > > which is trying to test for this is busted because "." in Tcl includes
> > > > "\n", i.e., the newline character.
> > > Oops, thi sis ugly.  Tranks for noticing that, Mark!
> > > I will fix the i386-* tests tonight.
> > ! /* { dg-final { scan-assembler "pand\[^\\n\]magic" } } */
> > ! /* { dg-final { scan-assembler "pandn\[^\\n\]magic" } } */
> Unforutnately this does not work.  Does anyone know of better way of
> encoding this in TCL except for using the newline character?

You lost a * after the \] - does adding that fix it?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer



More information about the Gcc mailing list