PATCH for Re: ABI breakage in 3.2.1, 3.3 and mainline

[Gerald Pfeifer]

On Fri, 31 Jan 2003, Loren James Rittle wrote:
>> Thanks!  I noticed that you committed the testcase to 3.2, 3.3, and
>> mainline, and the fix to 3.2 and mainline, but apparently not 3.3 yet.
>>
>> Was this intentional?
> You have Eagle eyes.  I am to blame for this.  I committed it, at the
> request of Gabriel.  The test against mainline and the 3.2 branch has
> completed, thus I installed it there ASAP (in the hopes of hitting the
> next 3.2.2 prerelease).  The test against 3.3 hasn't completed yet,

Not so much eagle eyes as a strong desire to ensure this is properly
fixed on all active branches. ;-)

(And I'd certainly not call proper testing as you have done as something
to be blamed for; rather to the contrary!)

> To get an exact list will be difficult.  Here is my best effort
> of broken ports based on config directory snippets:
>
> cygwin/i386
> freebsd/i386 (although, please explicitly mention that the FreeBSD 5.0
> 	      release, which used gcc 3.2.1, was OK)
> interix/i386
> linux-aout/i386
> mach/i386
> netbsd-aout/i386
> openbsd/i386
> darwin/i386

Thanks! I just installed the following update for the 3.2 changes
page; a bit late, but, well, don't ask. :-(

Gerald

Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-3.2/changes.html,v
retrieving revision 1.45
diff -u -3 -p -r1.45 changes.html
--- changes.html	7 Feb 2003 15:35:14 -0000	1.45
+++ changes.html	9 Feb 2003 23:24:21 -0000
@@ -102,6 +102,13 @@ new features that were not present in GC

 <h3>Bug Fixes</h3>

+<p>On the following i386-based systems GCC 3.2.1 broke the C ABI wrt.
+functions returning structures: Cygwin, FreeBSD (GCC 3.2.1 as shipped
+with FreeBSD 5.0 does not have this problem), Interix, a.out-based Linux
+and NetBSD, OpenBSD, and Darwin.  GCC 3.2.2 reverts this ABI change, and
+thus restores ABI-compatibility with previous releases (except GCC 3.2.1)
+on these platforms.</p>
+
 <p>This section lists the problem reports (PRs) from GCC's bug tracking
 system (GNATS) that are known to be fixed in the 3.2.2 release. This
 list might not be complete (that is, it is possible that some PRs