[tree-ssa]: Code movement is a pain in the ass.

Andrew MacLeod amacleod@redhat.com
Mon Aug 11 18:18:00 GMT 2003


On Sun, 2003-08-10 at 16:12, Diego Novillo wrote:
> On Sun, 2003-08-10 at 15:38, Daniel Berlin wrote:
> 
> > > I meant implementing bsi_move in terms of bsi_remove and bsi_insert.  
> > > Is
> > > that feasible?
> > Yes, but it will require adding an extra argument to bsi_remove and 
> > remove_stmt.
> > 
> Or commonize some of the code in bsi_remove/remove_stmt.  Though, if
> that's too intrusive then I guess we add the argument.
> 
> 

bsi_remove is pretty simple... If you really want to not duplicate that
piece of code, common it out into a new function, add the parameter and
call it from bsi_remove. I wouldn't want to see the API to bsi_remove()
changed.  remove_stmt() is a static function, so do whatever you want to
that :-)

Andrew



More information about the Gcc mailing list