[patch] Re: ARM: testsuite gcc.c-torture/execute/20020307-2.c failure

[Richard Earnshaw]

> Richard Earnshaw wrote:
> >>jeroen dobbelaere wrote:
> >>[...]
> >>
> >>
> >>>I have implemented this (similar to ia64) and I'm doing a regression 
> >>>test right
> >>>now (c only). First indication is that 20020307-2.c does not fail any 
> >>>more...
> >>>
> >>>2002-11-13  Jeroen Dobbelaere  <jeroen.dobbelaere@acunia.com>
> >>>
> >>>    * config/arm/arm.h (EXPAND_BUILTIN_VA_ARG,
> >>>    FUNCTION_ARG_PASS_BY_REFERENCE): Add.
> >>>    * config/arm/arm.c (arm_va_arg,
> >>>    arm_function_arg_pass_by_reference): Add.
> >>>    * config/arm/arm-protos.h: Add prototypes.
> >>>
> >>
> >>no regressions seen (checked gcc, g++, objc, f77), 8 failures gone...
> > 
> > 
> > Which configuration have you tested?
> 
> armv5l-unknown-linux-gnu; --with-cpu=xscale

Excellent.  It's just that if you use a simulator (eg arm-elf) then you 
end up only testing the compiler against libraries built with the same 
build of the compiler...

> 
> > 
> > It's quite important for a change like this that some checks with 
> > libraries built with older compilers are run to ensure we haven't changed 
> 
> what do you mean with 'older compilers' ?
> The glibc that is used has been compiled with a gcc-3.0.4.
> 
> > the ABI in some unexpected manner.
> > 
> > R.
> > 
> 
> Any suggestion on how to do this exactly ?

I think it's ok now.  You've tested it with linux; I've tested it with 
NetBSD over last night and I've checked that conventional structure 
passing hasn't changed it's behaviour.

So the patch is approved, thanks.

R.