Suspicious code in assign_parms

[Momchil Velikov]

>>>>> "Momchil" == Momchil Velikov <velco@fadata.bg> writes:

>>>>> "Momchil" == Momchil Velikov <velco@fadata.bg> writes:
Momchil> Note the underlined comparison.  Does it look right ?  I thought that
Momchil> should be ``promoted_nominal_mode == passed_mode''.

Momchil> Could somebody explain the meaning of and difference between the
Momchil> variables ``promoted_mode'' and ``promoted_nominal_mode'' throughout
Momchil> ``assign_parms'' ?

Momchil> Uh, never mind, figured that out (kinda) ...

But still ...
How about this patch ? Comments ?

***************
*** 4765,4771 ****
  	      if (GET_CODE (tempreg) == SUBREG
  		  && GET_MODE (tempreg) == nominal_mode
  		  && GET_CODE (SUBREG_REG (tempreg)) == REG
! 		  && nominal_mode == passed_mode
  		  && GET_MODE (SUBREG_REG (tempreg)) == GET_MODE (entry_parm)
  		  && GET_MODE_SIZE (GET_MODE (tempreg))
  		     < GET_MODE_SIZE (GET_MODE (entry_parm)))
--- 4763,4769 ----
  	      if (GET_CODE (tempreg) == SUBREG
  		  && GET_MODE (tempreg) == nominal_mode
  		  && GET_CODE (SUBREG_REG (tempreg)) == REG
! 		  && promoted_nominal_mode == promoted_mode
  		  && GET_MODE (SUBREG_REG (tempreg)) == GET_MODE (entry_parm)
  		  && GET_MODE_SIZE (GET_MODE (tempreg))
  		     < GET_MODE_SIZE (GET_MODE (entry_parm)))