outdated comment in sched-rgn.c or bug in find_basic_blocks ?
Joern Rennecke
joern.rennecke@superh.com
Thu Dec 19 17:57:00 GMT 2002
Jan Hubicka wrote:
> This looks fine to me. Perhaps we don't need to reffer to loop as loop
> is just temporary problem (I hope), instead we can mention that
> scheduler runs after the profile has been constructed or something like
> that.
Ok, next attempt:
--
--------------------------
SuperH (UK) Ltd.
2410 Aztec West / Almondsbury / BRISTOL / BS32 4QX
T:+44 1454 465658
-------------- next part --------------
Index: sched-rgn.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/sched-rgn.c,v
retrieving revision 1.52
diff -p -r1.52 sched-rgn.c
*** sched-rgn.c 19 Dec 2002 05:18:06 -0000 1.52
--- sched-rgn.c 19 Dec 2002 23:30:36 -0000
*************** init_regions ()
*** 2909,2925 ****
dominance_info dom;
struct edge_list *edge_list;
! /* The scheduler runs after flow; therefore, we can't blindly call
! back into find_basic_blocks since doing so could invalidate the
! info in global_live_at_start.
!
! Consider a block consisting entirely of dead stores; after life
! analysis it would be a block of NOTE_INSN_DELETED notes. If
! we call find_basic_blocks again, then the block would be removed
! entirely and invalidate our the register live information.
!
! We could (should?) recompute register live information. Doing
! so may even be beneficial. */
edge_list = create_edge_list ();
/* Compute the dominators and post dominators. */
--- 2909,2918 ----
dominance_info dom;
struct edge_list *edge_list;
! /* The scheduler runs after estimate_probabilities; therefore, we
! can't blindly call back into find_basic_blocks since doing so
! could invalidate the branch probability info. We could,
! however, call cleanup_cfg. */
edge_list = create_edge_list ();
/* Compute the dominators and post dominators. */
More information about the Gcc
mailing list