Unreviewed patches (was Re: Freeze timing and questions)

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Thu Dec 20 19:26:00 GMT 2001


 > From: DJ Delorie <dj@redhat.com>
 > 
 > > > Patch to avoid messy output when running configure:
 > > > http://gcc.gnu.org/ml/gcc-patches/2001-12/msg01721.html
 > > 
 > > This looks strange to me.  I'd rather aoliva or someone
 > > review this instead.
 > 
 > It's syntactically correct.  When you redirect output, the shell
 > redirects it for the subprocess. It doesn't always redirect its own
 > output, which is where the "file not found" message comes from
 > (depending on the shell).  With the parens, the shell is redirecting
 > the output of another /bin/sh, and *that* /bin/sh is the one with the
 > error message.
 > 
 > So if you don't have a problem with the diagnostic messages going
 > away, go ahead and approve it.  I don't see anything wrong with it.

DJ - Thanks for your more thorough and clear explanation of my patch. :-)

--
Kaveh R. Ghazi			Director of Systems Architecture
ghazi@caip.rutgers.edu		Qwest Global Services



More information about the Gcc mailing list