varasm patch breaks sh-coff

Zack Weinberg zack@wolery.cumb.org
Mon Sep 11 11:25:00 GMT 2000


On Mon, Sep 11, 2000 at 07:06:49PM +0100, Joern Rennecke wrote:
> This patch:

[        * varasm.c (make_decl_rtl): Restore leading star on
        DECL_ASSEMBLER_NAME set for decls with an asmspec. 
]

> breaks sh-coff.  In libgcc1-test.c, there is:
...

> Your patch causes "*start" to be used for the identifier.
> In sdbout.c:sdbout_symbol, the '*' is not stripped:
...
>       PUT_SDB_DEF (IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)));


PUT_SDB_DEF (and all the other macros in sdbout.c that use
ASM_OUTPUT_LABELREF) should be using assemble_name instead.  sdbout.c
is the only place in the compiler that does _not_ use assemble_name
for this purpose.

I can't test sh-coff; can you do the patch, please?

zw


More information about the Gcc mailing list