Bernd Schmidt, release manager for GCC 2.95.3

[Bernd Schmidt]

On Thu, 30 Nov 2000, Martin von Loewis wrote:

> > I'll need to rely on people with more knowledge of the C++ frontend
> > for this issue.  Martin, Jason, as far as I know the vtable-thunks
> > patch has been applied to the 2.95 branch already.  Is there any
> > chance whatsoever that it breaks binary compatibility?  If so, it
> > will have to be reverted.
> 
> In its current form, it does break binary compatibility. 
> 
> Before you outright revert it, I'd like to present the cases in which
> it currently breaks binary compatibility.

Please do (but it's unlikely to change the outcome, I'm afraid).

> Also, if that extra effort cannot be invested, it is straight-forward
> to disable the entire patch with two lines of linux-configuration
> changes, instead of removing that code.

Are those the following ones found in Franz Sirl's backport patch?


Bernd

Index: gcc/config/linux.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/linux.h,v
retrieving revision 1.8.8.1
diff -u -p -r1.8.8.1 linux.h
--- gcc/config/linux.h	2000/04/12 06:53:24	1.8.8.1
+++ gcc/config/linux.h	2000/11/25 18:15:08
@@ -89,7 +89,7 @@ Boston, MA 02111-1307, USA.  */
 
 #ifndef USE_GNULIBC_1
 #undef DEFAULT_VTABLE_THUNKS
-#define DEFAULT_VTABLE_THUNKS 2
+#define DEFAULT_VTABLE_THUNKS 1
 #endif
 
 #undef	LIB_SPEC
Index: gcc/config/alpha/linux-elf.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/alpha/linux-elf.h,v
retrieving revision 1.5.6.1
diff -u -p -r1.5.6.1 linux-elf.h
--- gcc/config/alpha/linux-elf.h	2000/04/12 06:53:24	1.5.6.1
+++ gcc/config/alpha/linux-elf.h	2000/11/25 18:15:08
@@ -38,7 +38,7 @@ Boston, MA 02111-1307, USA.  */
 
 #ifndef USE_GNULIBC_1
 #undef DEFAULT_VTABLE_THUNKS
-#define DEFAULT_VTABLE_THUNKS 2
+#define DEFAULT_VTABLE_THUNKS 1
 #endif
 
 #ifndef USE_GNULIBC_1
Index: gcc/config/arm/linux-elf.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/arm/linux-elf.h,v
retrieving revision 1.7.4.2
diff -u -p -r1.7.4.2 linux-elf.h
--- gcc/config/arm/linux-elf.h	2000/04/12 06:53:25	1.7.4.2
+++ gcc/config/arm/linux-elf.h	2000/11/25 18:15:08
@@ -39,7 +39,7 @@ Boston, MA 02111-1307, USA.  */
 
 /* This was defined in linux.h.  Define it here also. */
 #undef  DEFAULT_VTABLE_THUNKS
-#define DEFAULT_VTABLE_THUNKS   2
+#define DEFAULT_VTABLE_THUNKS   1
 
 /* Handle #pragma weak and #pragma pack.  */
 #define HANDLE_SYSV_PRAGMA
Index: gcc/config/i386/freebsd-elf.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/i386/Attic/freebsd-elf.h,v
retrieving revision 1.13.4.7
diff -u -p -r1.13.4.7 freebsd-elf.h
--- gcc/config/i386/freebsd-elf.h	2000/04/12 06:53:25	1.13.4.7
+++ gcc/config/i386/freebsd-elf.h	2000/11/25 18:15:09
@@ -37,7 +37,7 @@ Boston, MA 02111-1307, USA.  */
 
 /* Use more efficient ``thunks'' to implement C++ vtables. */
 #undef DEFAULT_VTABLE_THUNKS
-#define DEFAULT_VTABLE_THUNKS 2
+#define DEFAULT_VTABLE_THUNKS 1
 
 /* Override the default comment-starter of "/".  */
 #undef ASM_COMMENT_START
Index: gcc/config/rs6000/linux.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/rs6000/linux.h,v
retrieving revision 1.16.4.2
diff -u -p -r1.16.4.2 linux.h
--- gcc/config/rs6000/linux.h	2000/04/12 06:53:25	1.16.4.2
+++ gcc/config/rs6000/linux.h	2000/11/25 18:15:09
@@ -69,7 +69,7 @@ Boston, MA 02111-1307, USA.  */
 
 #undef DEFAULT_VTABLE_THUNKS
 #ifndef USE_GNULIBC_1
-#define DEFAULT_VTABLE_THUNKS 2
+#define DEFAULT_VTABLE_THUNKS 1
 #endif
 
 #undef JUMP_TABLES_IN_TEXT_SECTION
Index: gcc/config/sparc/linux.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/sparc/linux.h,v
retrieving revision 1.10.8.1
diff -u -p -r1.10.8.1 linux.h
--- gcc/config/sparc/linux.h	2000/04/12 06:53:26	1.10.8.1
+++ gcc/config/sparc/linux.h	2000/11/25 18:15:15
@@ -37,7 +37,7 @@ Boston, MA 02111-1307, USA.  */
 
 #ifndef USE_GNULIBC_1
 #undef DEFAULT_VTABLE_THUNKS
-#define DEFAULT_VTABLE_THUNKS 2
+#define DEFAULT_VTABLE_THUNKS 1
 #endif
 
 /* Use stabs instead of DWARF debug format.  */