Merged ARM-Thumb branch...

Scott Bambrough scottb@netwinder.org
Wed Feb 9 12:47:00 GMT 2000


Nick Clifton wrote:
> 
> I think you need to fix the parenthesising for this patch as well, to
> make it obvious that the tests only apply if flag_pic is true.  Say
> something like this:
 
It looks like you already fixed the parenthesising!  I have no objection to this
patch.  It's been around for a dogs age, and needs to be added.  If you already
have it in your source tree feel free to check it in.  If you need me to
resubmit it I will.

I'd add my first name to the ChangeLog entry: 
> 2000-02-09  Scott Bambrough  <scottb@netwinder.org>
              ^^^^^

> 2000-02-09  Bambrough  <scottb@netwinder.org>
> 
>         * config/arm/arm.md (movsi): In PIC mode, make sure that a
>         constant source address is legitimate.
> 
> Index: config/arm/arm.md
> ===================================================================
> RCS file: /cvs/gcc/egcs/gcc/config/arm/arm.md,v
> retrieving revision 1.34.2.11
> diff -p -r1.34.2.11 arm.md
> *** arm.md      2000/02/02 19:55:48     1.34.2.11
> --- arm.md      2000/02/09 19:29:00
> ***************
> *** 3793,3799 ****
>           }
>       }
> 
> !   if (CONSTANT_P (operands[1]) && flag_pic)
>       operands[1] = legitimize_pic_address
>         (operands[1], SImode, ((reload_in_progress || reload_completed)
>                              ? operands[0] : 0));
> --- 3793,3802 ----
>           }
>       }
> 
> !   if (flag_pic
> !       && (CONSTANT_P (operands[1])
> !        || symbol_mentioned_p (operands[1])
> !        || label_mentioned_p (operands[1])))
>       operands[1] = legitimize_pic_address
>         (operands[1], SImode, ((reload_in_progress || reload_completed)
>                              ? operands[0] : 0));

-- 
Scott Bambrough - Software Engineer
REBEL.COM    http://www.rebel.com
NetWinder    http://www.netwinder.org


More information about the Gcc mailing list