GCC 3.0 release criteria - __GNUC_MINOR__

[Loren James Rittle]

Joseph S. Myers wrote:

> While in most cases this may not break the software involved but simply
> reduce efficiency, it would probably be a good idea before the release for
> someone to grep large source trees (e.g. Linux distributions, BSDs) for
> incorrect use of __GNUC_MINOR__, so patches can be distributed.

Here are the results for the /usr/src tree on FreeBSD-3.4-STABLE (I
removed any matches on __GNUC_MINOR__ that appeared to be correct
usage by hand):

/usr/src/contrib/awk/awk.h:
#if __GNUC__ < 2 || __GNUC_MINOR__ < 7
/usr/src/contrib/binutils/bfd/bfd-in.h:
#if defined (__GNUG__) && (__GNUC_MINOR__ > 5)
/usr/src/contrib/binutils/bfd/bfd-in2.h:
#if defined (__GNUG__) && (__GNUC_MINOR__ > 5)
/usr/src/contrib/binutils/gas/as.h:
#if !defined (__GNUC__) || __GNUC_MINOR__ <= 5
#if __GNUC_MINOR__ < 6
/usr/src/contrib/gdb/gdb/defs.h:
# if defined(__GNUC__) && __GNUC__ >= 2 && __GNUC_MINOR__ >= 7
# if defined(__GNUC__) && __GNUC__ >= 2 && __GNUC_MINOR__ >= 4 && defined (__ANSI_PROTOTYPES)
/usr/src/contrib/libgmp/longlong.h:
#if __GNUC__ > 2 || __GNUC_MINOR__ >= 7
#if __GNUC__ > 2 || __GNUC_MINOR__ >= 7
/usr/src/gnu/usr.bin/binutils/libbfd/alpha/bfd.h:
#if defined (__GNUG__) && (__GNUC_MINOR__ > 5)
/usr/src/gnu/usr.bin/binutils/libbfd/i386/bfd.h:
#if defined (__GNUG__) && (__GNUC_MINOR__ > 5)

The FreeBSD kernel and user-space programs all appear OK.  Sadly,
the broken stuff w.r.t __GNUC_MINOR__ usage comes from GNU tree
imports!  Misuse of __GNUC_MINOR__ is still present in the official
joined binutils/gdb tree.

Regards,
Loren