> I see places where it is
> used in both contexts and, unless I'm missing something, we are missing
> conversions.
I suppose you mean this?
offset = size_binop (PLUS_EXPR, offset,
size_binop (EXACT_DIV_EXPR, var,
size_int (BITS_PER_UNIT)));
Yes. VAR is clearly bitsizetype and OFFSET is supposed to be sizetype
and there's no conversion.