Chill warning questions #2

[Kaveh R. Ghazi]

Dave,

	Here are more questions I have about warnings in the ch dir.
Would you please take a look?

		Thanks,
		--Kaveh



1.  Where should the parens go?

expr.c: In function `build_chill_card':
expr.c:1376: warning: suggest parentheses around comparison in operand of &

 > if (TREE_CODE (powerset) == CONSTRUCTOR & TREE_CONSTANT (powerset)
 >     && (size = int_size_in_bytes (TREE_TYPE (powerset))) >= 0)



2.  In the following case, did you mean to use "=", not "=="?
Or should the line be removed?

typeck.c: In function `build_chill_cast':
typeck.c:1214: warning: statement with no effect

 >   TREE_READONLY (expr) == TYPE_READONLY (type);
 >   return expr;



3.  Who here needs a cast, and to what?

expr.c: In function `chill_expand_expr':
expr.c:232: warning: comparison between signed and unsigned

 >   if (mode != Pmode && modifier == EXPAND_SUM)


4.  What should have been printed here?

tasking.c: In function `build_signal_descriptor':
tasking.c:1275: warning: char format, tree_node arg (arg 2)

 > tree signame = DECL_NAME (sigdef);
 > [...]
 > error ("SEND requires a SIGNAL; %s is not a SIGNAL name", signame);


--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Icon CMT Corp.