No Subject

[David S. Miller]

From: "David S. Miller" <davem@pierdol.cobaltmicro.com>
To: jfc@tiac.net
CC: egcs@cygnus.com
In-reply-to: < 199810031259.IAA08986@jfc.tiac.net > (message from John Carr on
	Sat, 03 Oct 1998 08:59:15 EDT)
Subject: Re: expand_builtin_dwarf_reg_size
References:  < 199810031259.IAA08986@jfc.tiac.net >

   From: John Carr <jfc@tiac.net>
   Date: Sat, 03 Oct 1998 08:59:15 EDT

   This change is wrong:

	   * dwarf2out.c (expand_builtin_dwarf_reg_size): Use
	   FIRST_PSEUDO_REGISTER as upper bound for last_end, not an
	   arbitrary constant.

   DBX register numbers can be larger than FIRST_PSEUDO_REGISTER.  The
   old code was wrong too, but this isn't the right fix.

Right you are, and for the curious there are exactly 3 places where
this is possible:

1) m68k/linux.h
2) pa/pa.h
3) sparc/sysv4.h

I would therefore suggest making a DBX_MAX_REGISTER_NUMBER, which by
default is FIRST_PSEUDO_REGISTER, and the 3 header files above can
override this as appropriate.

Later,
David S. Miller
davem@dm.cobaltmicro.com