system.h, gcc.c, toplev.c

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Thu Feb 19 10:47:00 GMT 1998


 > From: John Carr <jfc@mit.edu>
 > 
 > This patch reduces system.h to include a reasonable set of include
 > files, uses ANSI string functions when autoconf defines STDC_HEADERS,
 > makes corresponding changes to gcc.c, and converts toplev.c to use
 > system.h.

John,

	I think your proposed patch goes too far.  To date, you've
only given a rationale for removing stat.h (because on some SVR4
platforms it may cause some code bloat with static functions.)

	Centralized maintenance is a reason to keep everything else,
the extra compilation time is not large.

	How about we start with removing just stat.h and see if any
other headers cause problems?  Can we agree on that?

		--Kaveh

PS: I like your bcopy (etc) undef stuff, but just to be extra safe I
would check ifdef HAVE_MEM* in addition to or instead of STDC_HEADERS
before undef'ing the HAVE_B* functions.  Imagine using gcc for stage1 on
an old bsd system (without the mem* style functions,) it would pass the
STDC_HEADERS test by autoconf (because fixincludes would add the missing
headers, wouldn't it?)

--
Kaveh R. Ghazi			Project Manager / Custom Development
ghazi@caip.rutgers.edu		ICon CMT Corp.



More information about the Gcc mailing list