A libio patch for egcs

Per Bothner bothner@cygnus.com
Sat Feb 14 20:59:00 GMT 1998


> I added one more arg to _IO_getline and renamed it to _IO_new_getline.

_IO_new_getline is a bad name.  It is not descriptive.  All it says
is it is new - which will be false two years from now.

Furthermore, I don't really see the need for the extra eof argument.
Why not just use _IO_EOF_SEEN to check for EOF?

If you really need an extra argument, just add an extra argument to
_IO_getline.  It is not a public function, so it is not an ABI or
API change.

	--Per Bothner
Cygnus Solutions     bothner@cygnus.com     http://www.cygnus.com/~bothner



More information about the Gcc mailing list