egcs-980129, fixed ambiguous `else' warnings in the gcc/f/ dir.
Kaveh R. Ghazi
ghazi@caip.rutgers.edu
Thu Feb 12 20:07:00 GMT 1998
> From: Richard Henderson <rth@cygnus.com>
>
> On Wed, Feb 11, 1998 at 04:57:39PM -0500, Kaveh R. Ghazi wrote:
> > +++ egcs-980129/gcc/f/expr.c Tue Feb 3 15:50:59 1998
> > @@ -8761,10 +8761,12 @@
> > else
> > { /* The normal stuff. */
> > if (nbt == lbt)
> > - if (nbt == rbt)
> > - nkt = ffeinfo_kindtype_max (nbt, lkt, rkt);
> > - else
> > - nkt = lkt;
> > + {
> > + if (nbt == rbt)
> > + nkt = ffeinfo_kindtype_max (nbt, lkt, rkt);
> > + else
> > + nkt = lkt;
> > + }
> > else if (nbt == rbt)
> > nkt = rkt;
> > else
>
> It would be my preference that the pieces of the patch like this,
> in which the if-then-else tree is full, _not_ be installed. This
> will remind us that we should fix the bug in the warning code.
> r~
Is it a bug or a feature? Ie, is it good coding style to not
use braces even if the if-then-else tree is full?
--Kaveh
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu ICon CMT Corp.
More information about the Gcc
mailing list