gcc.c warning cleanup

Robert Lipe robertl@dgii.com
Sat Feb 7 12:43:00 GMT 1998


> 	Thanks for helping out.  Your patch looks great, it looks like

Thank you...on both counts.

> 	The only suggestion I have is that for strings.h you follow
> the convention of including string.h first and only get strings.h if
> string.h doesn't exist.  Ie,
> 
>  > #ifdef HAVE_STRING_H
>  > # include <string.h>
>  > #else
>  > # ifdef HAVE_STRINGS_H
>  > #  include <strings.h>
>  > # endif
>  > #endif

I'm not real fond of that, but if that's the preferred approach, it's
easy enough to resubmit them.

Why?   At least on OpenServer, the protos for things like bcopy, bcmp,
and bzero are in <strings.h> and definitely not in <string.h>.   With 
the logic you list, the protos for those functions will never be seen.

-- 
Robert Lipe       http://www.dgii.com/people/robertl       robertl@dgii.com



More information about the Gcc mailing list