egcs-980129, warning patches to alpha.c

Manfred.Hollstein@ks.sel.alcatel.de Manfred.Hollstein@ks.sel.alcatel.de
Fri Feb 6 05:56:00 GMT 1998


On Fri, 6 February 1998, 03:04:18, msimons@saic1.com wrote:

 > > Thu Feb  5 14:53:05 1998  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
 > >  
 > >         (add_long_const): Use HOST_WIDE_INT_PRINT_DEC as needed.
 > [...]
 > > @@ -3246,7 +3273,9 @@
 > >    if (sa_size != 0)
 > >      {
 > >        reg_mask |= 1 << REG_RA;
 > > -      fprintf (file, "\tstq $26,%d($%d)\n", reg_offset, sa_reg);
 > > +      fprintf (file, "\tstq $26,");
 > > +      fprintf (file, HOST_WIDE_INT_PRINT_DEC, reg_offset);
 > > +      fprintf (file, "($%d)\n", sa_reg);
 > >        reg_offset += 8;
 > >        int_reg_save_area_size += 8;
 > >      }
 > 
 > Kaveh,
 > 
 > I just glanced at your patch, couldn't we do this:
 >   fprintf (file, "\tstq $26," HOST_WIDE_INT_PRINT_DEC "($%d)\n", 
 >            reg_offset, sa_reg);
 > 
 >   it is much more condensed, the compiler will merge the strings for us.  =)
 > 

This of course would only work with an ANSI C compiler; e.g. SunOS's old
K&R cc will fail to concatenate string literals :-(

Manfred



More information about the Gcc mailing list