A patch for gcc/testsuite

H.J. Lu hjl@lucon.org
Fri Feb 6 00:57:00 GMT 1998


> 
> This is the wrong solution to this problem.  Please don't install this patch.
> The right solution is to add a `execution test - XFAIL *-*-*' to old-deja,
> in the spirit of `excess errors test - ' and then change `execution test fails'
> to be like `excess errors test fails'.  Then you will notice that:
> 
> egcs/gcc/testsuite/g++.old-deja/g++.jason/opeq5.C:// execution test fails - 
> egcs/gcc/testsuite/g++.old-deja/g++.law/code-gen3.C:// execution test fails - 
> egcs/gcc/testsuite/g++.old-deja/g++.mike/p7325.C:// execution test fails *-*-*
> 
> Should be change to use the new `execution test - XFAIL *-*-*' support.
> 

How about this patch?


-- 
H.J. Lu (hjl@gnu.org)
----
Thu Feb  5 23:17:37 1998  H.J. Lu  (hjl@gnu.org)

	* g++.old-deja/g++.jason/opeq5.C: Changed
	// execution test fails - ...
	to
	// execution test - XFAIL ...
	* g++.old-deja/g++.law/code-gen3.C: Ditto.
	* g++.old-deja/g++.mike/p6610a.C: Ditto.
	* g++.old-deja/g++.mike/p7325.C: Ditto.

	* lib/old-dejagnu.exp (old-dejagnu): Added the
	"execution test - XFAIL *-*-*" handling in the spirit of
	"excess errors test -". Changed the "execution test fails"
	handling to be like "excess errors test fails".

diff -x CVS -ur ../../../../import/egcs/gcc/testsuite/g++.old-deja/g++.jason/opeq5.C ./g++.old-deja/g++.jason/opeq5.C
--- ../../../../import/egcs/gcc/testsuite/g++.old-deja/g++.jason/opeq5.C	Mon Jan 12 17:03:54 1998
+++ ./g++.old-deja/g++.jason/opeq5.C	Thu Feb  5 16:29:02 1998
@@ -1,7 +1,7 @@
 // Testcase for tricky synthesized op= in complex inheritance situation.
 // See discussion in g++int.texi.
 
-// execution test fails - 
+// execution test - XFAIL *-*-*
 
 int count = 0;
 extern "C" int printf (const char *, ...);
diff -x CVS -ur ../../../../import/egcs/gcc/testsuite/g++.old-deja/g++.law/code-gen3.C ./g++.old-deja/g++.law/code-gen3.C
--- ../../../../import/egcs/gcc/testsuite/g++.old-deja/g++.law/code-gen3.C	Mon Jan 12 17:04:07 1998
+++ ./g++.old-deja/g++.law/code-gen3.C	Thu Feb  5 16:29:22 1998
@@ -1,5 +1,5 @@
 // GROUPS passed code-generation
-// execution test fails - 
+// execution test - XFAIL *-*-*
 // code-gen file
 // From: mscha@anne.wifo.uni-mannheim.de (Martin Schader)
 // Date:     Wed, 4 Aug 93 19:14:52 +0200
diff -x CVS -ur ../../../../import/egcs/gcc/testsuite/g++.old-deja/g++.mike/p6610a.C ./g++.old-deja/g++.mike/p6610a.C
--- ../../../../import/egcs/gcc/testsuite/g++.old-deja/g++.mike/p6610a.C	Wed Feb  4 14:17:55 1998
+++ ./g++.old-deja/g++.mike/p6610a.C	Thu Feb  5 18:26:41 1998
@@ -1,6 +1,6 @@
 // prms-id: 6610
 // There is a bug in vtable thunks with multiple/virtual inheritance.
-// execution test fails - XFAIL *-*-linux-gnu *-*-linux
+// execution test - XFAIL *-*-linux-gnu *-*-linux
 int fail = 1;
 struct B;
 struct A { virtual int f(const B*) = 0; int g(const B*); };
diff -x CVS -ur ../../../../import/egcs/gcc/testsuite/g++.old-deja/g++.mike/p7325.C ./g++.old-deja/g++.mike/p7325.C
--- ../../../../import/egcs/gcc/testsuite/g++.old-deja/g++.mike/p7325.C	Mon Jan 12 17:04:50 1998
+++ ./g++.old-deja/g++.mike/p7325.C	Thu Feb  5 16:30:30 1998
@@ -1,7 +1,7 @@
 // I hate this type of test case.  I'm not sure how to code it better.
 // See the PR for what this tests.
 // prms-id: 7325
-// execution test fails *-*-*
+// execution test - XFAIL *-*-*
 
 int fail = 0;
 
diff -x CVS -ur ../../../../import/egcs/gcc/testsuite/lib/old-dejagnu.exp ./lib/old-dejagnu.exp
--- ../../../../import/egcs/gcc/testsuite/lib/old-dejagnu.exp	Mon Jan 12 17:06:11 1998
+++ ./lib/old-dejagnu.exp	Thu Feb  5 16:27:34 1998
@@ -361,10 +361,16 @@
 	set message [concat $message $tmp]
     }
 
-    set tmp [process-option $prog "execution test fails" "an execution failure" EXEC $text]
+    set tmp [process-option $prog "execution test fails" "an execution failure" EXECO $text]
     if ![string match "" $tmp] then {
 	set execbug_flag 1
 	set message [concat $message $tmp]
+	warning "please use execution test - XFAIL *-*-* in $prog instead"
+    }
+
+    set tmp [process-option $prog "execution test - " "an excess error failure" EXEC $text]
+    if ![string match "" $tmp] then {
+	set message [concat $message $tmp]
     }
 
     set tmp [process-option $prog "excess errors test fails" "an excess error failure" EXCESSO $text]
@@ -472,7 +478,9 @@
 	    "XBADASM" {
 		x$uhoh "$name $pattern (test for bad assembler, line $line)"
 	    }
-	    "XEXEC" { }
+	    "XEXEC" {
+		set execbug_flag 1
+	    }
 	    "XEXCESS" {
 		set excessbug_flag 1
 	    }



More information about the Gcc mailing list