system.h & warnings (patch for gansidecl.h included)

Jeffrey A Law law@cygnus.com
Sat Apr 4 16:52:00 GMT 1998


  In message < 199804031726.MAA22875@caip.rutgers.edu >you write:

  > 	It provides for centralized maintenance.  I don't know if any
  > attributes were added after gcc-2.7, but the current ubiquitous test
  > assumes that all attributes work as of version 2.7.  That may not hold
  > in the future and we should have a centralized way of handling these on
  > a per attribute basis.  This ensures if we have to distinguish between
  > them for the purposes of figuring out which ones work as of some gcc
  > version, they are already separated in the source code and we don't have
  > to change more than one file. 
  > 
  > 	Below is the patch I came up with.  Is it okay to install?
I'm not convinced we need this kind of centralized maintenance for
attributes, since I don't forsee that we'll use them all that often.

However, I also don't see a good reason not to install your patch :-)

So, go ahead and install it :-)


  > Fri Apr  3 09:50:55 1998  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
  >  
  >         * gansidecl.h: Check if compiler supports __attribute__.  Provide
  >         definitions for ATTRIBUTE_UNUSED and ATTRIBUTE_PRINTF using
  >         __attribute__ when its available.  Also provide definitions for
  >         ATTRIBUTE_PRINTF_1, ATTRIBUTE_PRINTF_2 and ATTRIBUTE_PRINTF_3 in
  >         terms of ATTRIBUTE_PRINTF.
  >  
  >         * genoutput.c (process_template): Use ATTRIBUTE_UNUSED in place
  > 	of __attribute__.

jeff



More information about the Gcc mailing list