Remaining generic bits from sparc64-linux merge
Jeffrey A Law
law@cygnus.com
Sat Oct 18 00:28:00 GMT 1997
In message < 199710021950.PAA04406@jenolan.rutgers.edu >you write:
> Thu Oct 2 15:28:24 1997 David S. Miller <davem@tanya.rutgers.edu>
>
> * varasm.c (immed_double_const): Add casts to HOST_WIDE_INT where
> necessary.
> (const_hash): Hash val is unsigned long.
> (SYMHASH): Likewise.
>
> * tree.c (TYPE_HASH): Type of hash val is unsigned long.
Why are you changing these variables from a HOST_WIDE_INT to
unsigned longs?
> * rtl.c: Remove atol extern, include stdlib.h instead.
> (read_rtx): Use atol/atoq based upon disposition of
> HOST_WIDE_INT.
The inclusion of stdlib.h should be conditional on HAVE_STDLIB_H.
You also can't just delete the atol extern -- I would think you
would want to have autoconf determine if it's needed.
I would advise against using atoq since I doubt it's a function we
can really depend on.
> * genattrtab.c (write_test_expr): Use proper format string based
> upon disposition of HOST_BITS_PER_WIDE_INT.
> * genemit.c (gen_exp): Likewise.
> * genpeep.c (match_rtx): Likewise.
> * genrecog.c (write_tree_1): Likewise.
Is %llx something you can really rely upon? I don't think so. Is there
some way to handle this using standard format strings?
> * print-tree.c (print_node_brief): HOST_PTR_PRINTF format wants a
> char pointer, not HOST_WIDE_INT.
Sounds right.
> (print_node): Likewise. Also hash is unsigned long not
> HOST_WIDE_INT.
See above about unsigned long vs HOST_WIDE_INT.
> * gbl-ctors.h: Do not declare extern for atexit if both WINNT and
> NEED_ATEXIT are not defined.
I think this is OK.
> (yylex): Put casts in right place for args to build_int_2.
I'll just assume this is right :-)
jeff
More information about the Gcc
mailing list