[COMMITTED] Regenerate c.opt.urls

Mark Wielaard mark@klomp.org
Wed Jul 17 16:07:20 GMT 2024


Hi,

On Wed, 2024-07-17 at 13:55 +0200, Mark Wielaard wrote:
> On Sun, 2024-07-14 at 15:31 +0200, Alejandro Colomar wrote:
> > On Sun, Jul 14, 2024 at 01:37:02PM GMT, Jonathan Wakely wrote:
> > > On Sun, 14 Jul 2024, 12:30 Alejandro Colomar via Gcc-help, <
> > > gcc-help@gcc.gnu.org> wrote:
> > > > Did I break anything?  I see the failure being `git diff --exit-code`,
> > > > which doesn't seem like anything broken, but I don't know what that test
> > > > is for, so I'll ask.
> > > > 
> > > 
> > > It checks that necessary auto-generated files have been regenerated and
> > > committed.
> > > 
> > > If you didn't do anything related to that warning option that would have
> > > affected the c.opts.urls file then it wasn't you (I think it was a change
> > > from Marek).
> > 
> > I did add that warning option:
> > 
> > 	commit 44c9403ed1833ae71a59e84f9e37af3182be0df5
> > 	Author:     Alejandro Colomar <alx@kernel.org>
> > 	AuthorDate: Sat Jun 29 15:10:43 2024 +0200
> > 	Commit:     Martin Uecker <uecker@gcc.gnu.org>
> > 	CommitDate: Sun Jul 14 11:41:00 2024 +0200
> > 
> > 	    c, objc: Add -Wunterminated-string-initialization
> > 	    
> > 	    Warn about the following:
> > 	    
> > 		char  s[3] = "foo";
> > 
> > I guess I should have committed some re-generated files?  Is that
> > documented somewhere?
> 
> Adding David Malcolm to CC who might know where this is documented.
> 
> But yes, after adding a new warning option you should run:
> 
> make html && cd gcc && make regenerate-opt-urls
> 
> This will produce the needed opt.url changes you should commit together
> with your change. In this case:
> 
> diff --git a/gcc/c-family/c.opt.urls b/gcc/c-family/c.opt.urls
> index 1b60ae4847b..df5f58a1eee 100644
> --- a/gcc/c-family/c.opt.urls
> +++ b/gcc/c-family/c.opt.urls
> @@ -870,6 +870,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wno-unknown-pragmas) LangUrlSuffix_D(gd
>  Wunsuffixed-float-constants
>  UrlSuffix(gcc/Warning-Options.html#index-Wno-unsuffixed-float-constants)
>  
> +Wunterminated-string-initialization
> +UrlSuffix(gcc/Warning-Options.html#index-Wno-unterminated-string-initialization)
> +
>  Wunused
>  UrlSuffix(gcc/Warning-Options.html#index-Wno-unused)

I made sure that was also generated locally and pushed the attached to
make the autoregen buildbot happy.

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Regenerate-c.opt.urls.patch
Type: text/x-patch
Size: 1050 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-testresults/attachments/20240717/d219ede2/attachment.bin>


More information about the Gcc-testresults mailing list