[COMMITTED 20/43] gccrs: rust: Fix ICE in function_set_parameters

[arthur.cohen@embecosm.com]

From: Egas Ribeiro <egas.g.ribeiro@tecnico.ulisboa.pt>

When lowering a function to HIR with a refutable pattern in its
parameter pattern, we were ICE'ing due to a lack of checks for invalid
refutable patterns. Fix this by erroring on invalid patterns while
lowering a function.

	Fixes Rust-GCC/gccrs#3919

gcc/rust/ChangeLog:

	* hir/rust-ast-lower-item.cc (ASTLoweringItem::visit): added
	refutable pattern checks for function params.

gcc/testsuite/ChangeLog:

	* rust/compile/issue-3919-ice-func-parms.rs: New test.

Signed-off-by: Egas Ribeiro <egas.g.ribeiro@tecnico.ulisboa.pt>
---
 gcc/rust/hir/rust-ast-lower-item.cc           | 19 +++++++++++++++++++
 .../rust/compile/issue-3919-ice-func-parms.rs |  4 ++++
 2 files changed, 23 insertions(+)
 create mode 100644 gcc/testsuite/rust/compile/issue-3919-ice-func-parms.rs

diff --git a/gcc/rust/hir/rust-ast-lower-item.cc b/gcc/rust/hir/rust-ast-lower-item.cc
index 2d3d021f837..96b6aefbc6a 100644
--- a/gcc/rust/hir/rust-ast-lower-item.cc
+++ b/gcc/rust/hir/rust-ast-lower-item.cc
@@ -455,6 +455,25 @@ ASTLoweringItem::visit (AST::Function &function)
 
       auto translated_pattern = std::unique_ptr<HIR::Pattern> (
 	ASTLoweringPattern::translate (param.get_pattern ()));
+
+      switch (param.get_pattern ().get_pattern_kind ())
+	{
+	case AST::Pattern::Kind::Identifier:
+	case AST::Pattern::Kind::Wildcard:
+	case AST::Pattern::Kind::Tuple:
+	case AST::Pattern::Kind::Struct:
+	case AST::Pattern::Kind::TupleStruct:
+	case AST::Pattern::Kind::Reference:
+	case AST::Pattern::Kind::Grouped:
+	case AST::Pattern::Kind::Slice:
+	case AST::Pattern::Kind::Rest:
+	  break;
+	default:
+	  rust_error_at (param.get_locus (),
+			 "refutable pattern in function argument");
+	  continue;
+	}
+
       auto translated_type = std::unique_ptr<HIR::Type> (
 	ASTLoweringType::translate (param.get_type ()));
 
diff --git a/gcc/testsuite/rust/compile/issue-3919-ice-func-parms.rs b/gcc/testsuite/rust/compile/issue-3919-ice-func-parms.rs
new file mode 100644
index 00000000000..3305762bbb9
--- /dev/null
+++ b/gcc/testsuite/rust/compile/issue-3919-ice-func-parms.rs
@@ -0,0 +1,4 @@
+#![feature(no_core)]
+#![no_core]
+
+fn func(1: i32) {} // { dg-error "refutable pattern in function argument" }
-- 
2.50.1