[COMMITTED 112/144] gccrs: Do not assert insertion result
arthur.cohen@embecosm.com
arthur.cohen@embecosm.com
Wed Mar 19 14:44:33 GMT 2025
From: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
We might have some duplicated name in some pattern and we should
therefore not assert the non duplication of identifiers.
gcc/rust/ChangeLog:
* resolve/rust-late-name-resolver-2.0.cc (Late::visit): Remove
assertion and explicitely tells why we ignore the insertion result.
Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
---
gcc/rust/resolve/rust-late-name-resolver-2.0.cc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/rust/resolve/rust-late-name-resolver-2.0.cc b/gcc/rust/resolve/rust-late-name-resolver-2.0.cc
index fa759d7bc8b..df67b4f9873 100644
--- a/gcc/rust/resolve/rust-late-name-resolver-2.0.cc
+++ b/gcc/rust/resolve/rust-late-name-resolver-2.0.cc
@@ -152,10 +152,10 @@ Late::visit (AST::IdentifierPattern &identifier)
// do we insert in labels or in values
// but values does not allow shadowing... since functions cannot shadow
// do we insert functions in labels as well?
- auto ok
- = ctx.values.insert (identifier.get_ident (), identifier.get_node_id ());
- rust_assert (ok);
+ // We do want to ignore duplicated data because some situations rely on it.
+ std::ignore
+ = ctx.values.insert (identifier.get_ident (), identifier.get_node_id ());
}
void
--
2.45.2
More information about the Gcc-rust
mailing list