[COMMITTED 117/145] gccrs: Fix optional trait parsing

arthur.cohen@embecosm.com arthur.cohen@embecosm.com
Mon Mar 17 15:33:15 GMT 2025


From: dave <dave@dmetwo.org>

gcc/rust/ChangeLog:

	* typecheck/rust-hir-type-check-item.cc (TypeCheckItem::visit): Check for ?Trait in visitor

gcc/testsuite/ChangeLog:

	* rust/compile/issue-2725.rs: New test.

Signed-off-by: Dave Evans <dave@dmetwo.org>
---
 gcc/rust/typecheck/rust-hir-type-check-item.cc | 18 ++++++++++++++++++
 gcc/testsuite/rust/compile/issue-2725.rs       |  3 +++
 2 files changed, 21 insertions(+)
 create mode 100644 gcc/testsuite/rust/compile/issue-2725.rs

diff --git a/gcc/rust/typecheck/rust-hir-type-check-item.cc b/gcc/rust/typecheck/rust-hir-type-check-item.cc
index 317d16700aa..68e206924bb 100644
--- a/gcc/rust/typecheck/rust-hir-type-check-item.cc
+++ b/gcc/rust/typecheck/rust-hir-type-check-item.cc
@@ -609,6 +609,24 @@ TypeCheckItem::visit (HIR::Module &module)
 void
 TypeCheckItem::visit (HIR::Trait &trait)
 {
+  if (trait.has_type_param_bounds ())
+    {
+      for (auto &tp_bound : trait.get_type_param_bounds ())
+	{
+	  if (tp_bound.get ()->get_bound_type ()
+	      == HIR::TypeParamBound::BoundType::TRAITBOUND)
+	    {
+	      HIR::TraitBound &tb
+		= static_cast<HIR::TraitBound &> (*tp_bound.get ());
+	      if (tb.get_polarity () == BoundPolarity::AntiBound)
+		{
+		  rust_error_at (tb.get_locus (),
+				 "%<?Trait%> is not permitted in supertraits");
+		}
+	    }
+	}
+    }
+
   TraitReference *trait_ref = TraitResolver::Resolve (trait);
   if (trait_ref->is_error ())
     {
diff --git a/gcc/testsuite/rust/compile/issue-2725.rs b/gcc/testsuite/rust/compile/issue-2725.rs
new file mode 100644
index 00000000000..a344bc8d464
--- /dev/null
+++ b/gcc/testsuite/rust/compile/issue-2725.rs
@@ -0,0 +1,3 @@
+#[lang = "sized"]
+pub trait Sized {}
+trait Trait: ?Sized {} // { dg-error ".?Trait. is not permitted in supertraits" }
-- 
2.45.2



More information about the Gcc-rust mailing list