[PATCH][15.2] nr2.0: late: Correctly initialize funny_error member

[Marc Poulhiès]

April 29, 2025 at 10:39 AM, "Andrew Pinski" <pinskia@gmail.com mailto:pinskia@gmail.com?to=%22Andrew%20Pinski%22%20%3Cpinskia%40gmail.com%3E > wrote:


> 
> On Tue, Apr 29, 2025 at 1:26 AM <arthur.cohen@embecosm.com> wrote:
> 
> > 
> > From: Arthur Cohen <arthur.cohen@embecosm.com>
> > 
> >  Hi everyone,
> > 
> >  We noticed inconsistent errors when running name-resolution 2.0 on
> >  certain files, where an invalid error was triggered and the message was
> >  from the `funny_ice` error finalizer function we had added as an easter
> >  egg. We realized yesterday that the undefined value was actually our
> >  `funny_error` boolean, which is supposed to be set only when resolving
> >  specific easter eggs `AST::IdentifierExpr`s.
> > 
> >  Since `funny_error` is a boolean, it does not get default-initialized in
> >  the constructor of `Late` - which this patch corrects.
> > 
> >  I will be pushing it to trunk directly, but this email specifically
> >  concerns its port into 15.2.
> > 
> I am not sure if using NSDMI might be a better style here than doing
> it in the constructor.
> 

We discussed this before sending the patch but we didn't have any strong arguments for/against any solution. Do you have any?

Thanks,
Marc