4 GCC HEAD regressions, 4 new, with your patch on 2005-03-04T06:26:05Z.

[Daniel Berlin]

On Sun, 2005-03-06 at 11:08 -0500, Andrew Pinski wrote:
> On Mar 4, 2005, at 2:06 PM, GCC regression checker wrote:
> 
> > With your recent patch, GCC HEAD has some regression test failures,
> > which used to pass.  There are 4 new failures, and 0
> > failures that existed before and after that patch; 0 failures
> > have been fixed.
> >
> > The new failures are:
> > native gcc.sum gcc.dg/pch/save-temps-1.c
> > native gcc.sum gcc.dg/pch/static-1.c
> > native gcc.sum gcc.dg/pch/static-2.c
> > native gcc.sum gcc.dg/pch/static-3.c
> 
> 
> Caused by:
> 2005-03-03  Daniel Berlin <dberlin@dbrelin.org>
> 
>          Fix PR debug/20253
> 
>          * c-opts.c (c_common_parse_file): Call start_source_file
>          and end_source_file at the approriate times.
> The diff in the assembly:
> line #22
> <       .stabs   
> "/Users/pinskia/src/new-fold/gcc/gcc/testsuite/gcc.dg/pch/save-temps 
> -1.c",130,0,0,0
>  >       .stabs  "./save-temps-1.h",130,0,0,0
> line #29
> <       .stabn  162,0,0,0
>  > .comm _x,4
> line #30
> < .comm _x,4
>  >       .stabs  "x:G(2,1)",32,0,7,0
> 
> So just debugging information is wrong.

It's probably wrong with pch, but not without it now. I'll look into it.
> 

I asked devang to verify that this worked okay on darwin, and he said he
did.

Note this only affects STABS default platforms. On i686, i get:

PASS: ./save-temps-1.h -O0 -g (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c -O0 -g (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c -O0 -g (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c -O0 -g assembly comparison
PASS: ./save-temps-1.h  -O0  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O0  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O0  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O0  assembly comparison
PASS: ./save-temps-1.h  -O1  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O1  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O1  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O1  assembly comparison
PASS: ./save-temps-1.h  -O2  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O2  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O2  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O2  assembly comparison
PASS: ./save-temps-1.h  -O3 -fomit-frame-pointer  (test for excess
errors)
PASS: gcc.dg/pch/save-temps-1.c  -O3 -fomit-frame-pointer  (test for
excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O3 -fomit-frame-pointer  (test for
excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O3 -fomit-frame-pointer  assembly
comparison
PASS: ./save-temps-1.h  -O3 -g  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O3 -g  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O3 -g  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -O3 -g  assembly comparison
PASS: ./save-temps-1.h  -Os  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -Os  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -Os  (test for excess errors)
PASS: gcc.dg/pch/save-temps-1.c  -Os  assembly comparison
etc


I'll look into this on monday when i get back near my mac.
--Dan