4 GCC regressions, 1 new, with your patch on 2003-09-14T12:36:53Z.

[Alexandre Oliva]

On Sep 14, 2003, Andrew Pinski <pinskia@physics.uc.edu> wrote:

> This is most definitely this patch:

> +2003-09-14  Alexandre Oliva  <aoliva@redhat.com>
> +
> +	* c-ppoutput.c (cb_line_change): Revert 2003-08-04's change.
> +	* c-lex.c (cb_line_change): Skip line changing whenever
> +	c-ppoutput.c would.

Indeed.

> The problem is that the line number is wrong:
> /Users/regress/tbox/cvs-gcc/gcc/gcc/testsuite/gcc.dg/pragma-darwin.c:0:
> warning: malformed '#pragma options', ignoring^M

No wonder, as the caller simply tells the callee to ignore it.

Here's a patch that fixes it.

I've tested it with the following test file and -Wunknown-pragmas,
with and without -save-temps.  All warning messages came out at the
right spot, and so did the pragmas in the preprocessed output.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.c
Type: application/octet-stream
Size: 319 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-regression/attachments/20030915/d5fe4381/attachment.obj>
-------------- next part --------------


Ok to install?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cpp-no-pragma-line-change.patch
Type: text/x-patch
Size: 952 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-regression/attachments/20030915/d5fe4381/attachment.bin>
-------------- next part --------------

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer