14 GCC regressions, 11 new, with your patch on 2003-07-05T14:15:01Z.

[Geoff Keating]

"Zack Weinberg" <zack@codesourcery.com> writes:

> Andrew Pinski <pinskia@physics.uc.edu> writes:
...
> > All of these really are caused by Zack's patch which added USC to CPP
> > but Darwin does not iconv so they fail.
> 
> Either we need to put GNU iconv into the GCC distribution, or all
> these tests are going to have to be XFAILed on targets that don't have
> iconv.  Personally I lean towards importing GNU iconv, as this will
> provide consistent behavior across hosts and let me get rid of some
> dodgy fallback logic.
> 
> > gcc.c-torture/execute/wchar_t-1.c and
> > gcc.c-torture/execute/widechar-2.c: fails on execution.
> 
> These may be worth further investigation, as they suggest that the
> fallback logic doesn't work.

I'm inclined to agree.  GCC will be simpler if we can always assume
that iconv is provided, and users will find it easier to build GCC if
iconv is always included and they don't have to go hunting for it.

-- 
- Geoffrey Keating <geoffk@geoffk.org>