libgcj/1736

[Billinghurst, David (CRTS)]

The following reply was made to PR libgcj/1736; it has been noted by GNATS.

From: "Billinghurst, David (CRTS)" <David.Billinghurst@riotinto.com>
To: "'Bryce McKinlay'" <bryce@albatross.co.nz>
Cc: "'gcc-gnats@gcc.gnu.org'" <gcc-gnats@gcc.gnu.org>
Subject: RE: libgcj/1736
Date: Mon, 26 Mar 2001 23:59:25 -0000

 Attached is a patch to Makefile.am for this.  It isn't fully tested, as I am
 having autotools problems. However:
 *	it is similar to the existing code
 *	corresponding changes to the Makefile did the right thing and 
 *	I could generate a reasonable Makefile.in.
 
 The change to the libffi_files macro works around a quoting problem.
 
 Unfortunately this just reveals another libtool problem, which I haven't
 looked at yet.  Still, it is progress.
 
 Index: Makefile.am
 ===================================================================
 RCS file: /cvs/gcc/egcs/libjava/Makefile.am,v
 retrieving revision 1.134
 diff -c -r1.134 Makefile.am
 *** Makefile.am	2001/03/23 05:18:16	1.134
 --- Makefile.am	2001/03/26 23:56:11
 ***************
 *** 132,138 ****
   x_javao_files = $(x_java_source_files:.java=.lo)
   
   ## Extract the libffi object file names.
 ! libffi_files = `$(AR) t ../libffi/.libs/libffi.a 2>/dev/null | sed
 's/\.o/\.lo/g' | sed 's/^/..\/libffi\//g'`
   
   libgcj_la_SOURCES = prims.cc posix.cc jni.cc exception.cc \
   	resolve.cc defineclass.cc interpret.cc name-finder.cc \
 --- 132,138 ----
   x_javao_files = $(x_java_source_files:.java=.lo)
   
   ## Extract the libffi object file names.
 ! libffi_files = $shell($(AR) t ../libffi/.libs/libffi.a 2>/dev/null | sed
 's/\.o/\.lo/g' | sed 's/^/..\/libffi\//g')
   
   libgcj_la_SOURCES = prims.cc posix.cc jni.cc exception.cc \
   	resolve.cc defineclass.cc interpret.cc name-finder.cc \
 ***************
 *** 265,272 ****
   ## Pass the list of object files to libtool in a temporary file to 
   ## avoid tripping platform command line length limits.
   libgcj.la: $(libgcj_la_OBJECTS) $(libgcj_la_DEPENDENCIES)
 ! 	@echo $(libgcj_la_OBJECTS) > libgcj.objectlist;
 ! 	@echo $(libgcj_la_LIBADD) >> libgcj.objectlist;
   	$(libgcj_la_LINK) -objectlist libgcj.objectlist -rpath
 $(toolexeclibdir) $(libgcj_la_LDFLAGS) $(LIBS)
   
   libgcjx.la: $(libgcjx_la_OBJECTS) $(libgcjx_la_DEPENDENCIES)
 --- 265,273 ----
   ## Pass the list of object files to libtool in a temporary file to 
   ## avoid tripping platform command line length limits.
   libgcj.la: $(libgcj_la_OBJECTS) $(libgcj_la_DEPENDENCIES)
 ! 	@:  $(shell echo Creating list of object files ...) \
 ! 	$(shell rm -f libgcj.objectlist || :) \
 ! 	$(foreach libgcj.object,$+,$(shell echo $(libgcj.object) >>
 libgcj.objectlist))
   	$(libgcj_la_LINK) -objectlist libgcj.objectlist -rpath
 $(toolexeclibdir) $(libgcj_la_LDFLAGS) $(LIBS)
   
   libgcjx.la: $(libgcjx_la_OBJECTS) $(libgcjx_la_DEPENDENCIES)
 
 
 > -----Original Message-----
 > From:	Bryce McKinlay [SMTP:bryce@albatross.co.nz]
 > Sent:	Saturday, 24 March 2001 9:05
 > To:	Billinghurst, David (CRTS)
 > Cc:	bryce@gcc.gnu.org; gcc-prs@gcc.gnu.org
 > Subject:	Re: libgcj/1736
 > 
 > OK, Tom and Oliva thought that might happen.
 > 
 > In Makefile.am, theres a line that says:
 > 
 > ## Create a list of all Java sources, without exceeding any shell limits.
 > 
 > followed by some code that uses a foreach loop to echo the filenames one
 > at a
 > time.
 > 
 > Could you try adapting that code to work for the objectlist case?
 > 
 > regards
 > 
 >   [ bryce ]
 >