[PATCH 2/5] libgomp: Ensure memory sync after performing tasks

Prathamesh Kulkarni prathameshk@nvidia.com
Sat Jan 31 05:05:20 GMT 2026



> -----Original Message-----
> From: Prathamesh Kulkarni <prathameshk@nvidia.com>
> Sent: 20 January 2026 09:48
> To: Tobias Burnus <tburnus@baylibre.com>; Matthew Malcomson
> <mmalcomson@nvidia.com>; gcc-patches@gcc.gnu.org; Jakub Jelinek
> <jakub@redhat.com>
> Cc: Thomas Schwinge <tschwinge@baylibre.com>; Andrew Stubbs
> <ams@baylibre.com>; Tom de Vries <tdevries@suse.de>; Sebastian Huber
> <sebastian.huber@embedded-brains.de>
> Subject: RE: [PATCH 2/5] libgomp: Ensure memory sync after performing
> tasks
> 
> External email: Use caution opening links or attachments
> 
> 
> > -----Original Message-----
> > From: Tobias Burnus <tburnus@baylibre.com>
> > Sent: 20 January 2026 02:39
> > To: Prathamesh Kulkarni <prathameshk@nvidia.com>; Matthew Malcomson
> > <mmalcomson@nvidia.com>; gcc-patches@gcc.gnu.org; Jakub Jelinek
> > <jakub@redhat.com>
> > Cc: Thomas Schwinge <tschwinge@baylibre.com>; Andrew Stubbs
> > <ams@baylibre.com>; Tom de Vries <tdevries@suse.de>; Sebastian Huber
> > <sebastian.huber@embedded-brains.de>
> > Subject: Re: [PATCH 2/5] libgomp: Ensure memory sync after
> performing
> > tasks
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Hi Prathamesh,
> >
> > Prathamesh Kulkarni wrote:
> > > The attached patch similarly adds target pragmas to the test as
> > previous patch.
> > > Does it look OK ?
> >
> > Thanks for revising Matthew's patch.
> >
> > Yes, LGTM. – However, except for 'Daily bump.', it seems to be
> > uncommon to have a '.' at the end of the first line (summary) of the
> > git commit; hence, consider removing it.
> Thanks, adjusted the commit summary and committed to trunk in:
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=304d08fea9e68c5b48065328
> 16b58d33a15a917d
Hi Tobias,
Sorry I messed up the newly added test (pr122356.c) while committing, and Linaro CI reported the test failing:
https://linaro.atlassian.net/browse/GNU-1822

This happens because full_data is not initialized to 0 on second call to test() on host, which results in call to abort.
The attached patch modifies pr122356.c (and similarly pr122314.c) to initialize full_data to 0 at beginning of test().

With patch, running make check-target-libgomp RUNTESTFLAGS="c.exp=pr122356.c" shows:

                === libgomp Summary ===
# of expected passes            2

OK to commit ?

Thanks,
Prathamesh
> 
> Thanks,
> Prathamesh
> >
> > Tobias

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: p-467-test.txt
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20260131/a47f3664/attachment-0001.txt>


More information about the Gcc-patches mailing list