[PATCH v5 03/10] OpenMP: Remove dead code from declare variant reimplementation
Tobias Burnus
tburnus@baylibre.com
Thu Jan 2 15:02:09 GMT 2025
Hi Sandra,
Sandra Loosemore wrote:
> After reimplementing late resolution of "declare variant", the
> declare_variant_alt and calls_declare_variant_alt flags on struct
> cgraph_node are no longer used by anything. For the purposes of
> marking functions that need late resolution, the
> has_omp_variant_constructs flag has replaced
> calls_declare_variant_alt.
[…]
LGTM. — Admittedly, I have locally not applied the posted patch but
Sandra's not yet posted rediffed patch, which differs only in two times
two additional lines in a function deleted here and changes in the
context lines, untouched by the patch but which will confuse 'patch'.
→ 01 (previously approved; rediff only differs in small line-number
shifts, which patch handles silently) — and (this) 03 are okay however,
I still need to finish reviewing 02, which is the complex core patch.
Tobias
More information about the Gcc-patches
mailing list