[PATCH v11] ada: fix timeval timespec on 32 bits archs with 64 bits time_t [PR114065]

Nicolas Boulenguez nicolas@debian.org
Thu Oct 17 09:46:02 GMT 2024


> > > It may be surprising to have the RTEMS file used by other OS. The
> > > original comment should have mentionned that in the first place, but
> > > the file was only used with RTEMS. With your change, the file is
> > > effectively shared, so it would be best to rename it.
> > 
> > Could you please suggest an appropriate file name?  This may be
> > obvious for you, but with my limited knowledge of GNAT internals, the
> > diff between s-osprim__rtems.adb and __unix/optide.adb is not
> > sufficient to guess why a separate implementation is/was required.
> 
> Would it be possible to drop it altogether and use s-osprim__posix.adb instead?
> Otherwise what's the remaining difference between
> s-osprim__posix.adb and s-osprim__rtems.adb? The difference should
> help us find a proper name based on properties of the file.

At first view, it seems possible and desirable to merge _posix and
_rtems, but working on this right now would be counter-productive.

I suggest to apply patches 1-2 and fix PR114065 first.

Then the cosmetic changes in patches 3-6 (and possibly a trivial
backport of 8).

After that, we will have all the time in the long winter afternoons to
discuss file names in patch 7.

> Can you post also a diff between version 11 and version 12? It's not
> practical to review the complete changes from scratch at this stage,
> the patch is too big.

The diff between git version branches are attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v10.diff
Type: text/x-diff
Size: 18277 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20241017/818757a2/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v11.diff
Type: text/x-diff
Size: 549 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20241017/818757a2/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v12.diff
Type: text/x-diff
Size: 1071 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20241017/818757a2/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v7.diff
Type: text/x-diff
Size: 11018 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20241017/818757a2/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v8.diff
Type: text/x-diff
Size: 5416 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20241017/818757a2/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v9.diff
Type: text/x-diff
Size: 426 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20241017/818757a2/attachment-0011.bin>


More information about the Gcc-patches mailing list