[PATCH 1/3] cfgexpand: Expand comment on when non-var clobbers can show up

[Richard Biener]

On Thu, Oct 3, 2024 at 6:09 PM Andrew Pinski <quic_apinski@quicinc.com> wrote:
>
> The comment here is not wrong, just it would be better if mentioning
> the C++ front-end instead of just the nested function lowering.

OK

> gcc/ChangeLog:
>
>         * cfgexpand.cc (add_scope_conflicts_1): Expand comment
>         on when non-var clobbers show up.
>
> Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
> ---
>  gcc/cfgexpand.cc | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/cfgexpand.cc b/gcc/cfgexpand.cc
> index f32cf1b20c9..6c1096363af 100644
> --- a/gcc/cfgexpand.cc
> +++ b/gcc/cfgexpand.cc
> @@ -639,8 +639,9 @@ add_scope_conflicts_1 (basic_block bb, bitmap work, bool for_conflict)
>         {
>           tree lhs = gimple_assign_lhs (stmt);
>           unsigned *v;
> -         /* Nested function lowering might introduce LHSs
> -            that are COMPONENT_REFs.  */
> +         /* Handle only plain var clobbers.
> +            Nested functions lowering and C++ front-end inserts clobbers
> +            which are not just plain variables.  */
>           if (!VAR_P (lhs))
>             continue;
>           if (DECL_RTL_IF_SET (lhs) == pc_rtx
> --
> 2.34.1
>