[PATCH] [tree-prof] skip if errors were seen [PR113681]
Jeff Law
jeffreyalaw@gmail.com
Fri Mar 22 18:10:41 GMT 2024
On 3/9/24 2:11 AM, Alexandre Oliva wrote:
>
> ipa_tree_profile asserts that the symtab is in IPA_SSA state, but we
> don't reach that state and ICE if e.g. ipa-strub passes report errors.
> Skip this pass if errors were seen.
>
> Regstrapped on x86_64-linux-gnu. Ok to install?
>
>
> for gcc/ChangeLog
>
> PR tree-optimization/113681
> * tree-profiling.cc (pass_ipa_tree_profile::gate): Skip if
> seen_errors.
>
> for gcc/testsuite/ChangeLog
>
> PR tree-optimization/113681
> * c-c++-common/strub-pr113681.c: New.
So I've really never dug into strub, but this would seem to imply that
an error from strub is non-fatal? Are we going to end up having to
make a similar change to gate most passes if strub let's things to
forward rather than causing a graceful exit?
jeff
More information about the Gcc-patches
mailing list