[PATCH] i386: Fix regression after refactoring legitimize_pe_coff_symbol, ix86_GOT_alias_set and PE_COFF_LEGITIMIZE_EXTERN_DECL

Evgeny Karpov Evgeny.Karpov@microsoft.com
Thu Jun 27 10:54:17 GMT 2024


Thursday, June 27, 2024 11:31 AM
Christophe Lyon <christophe.lyon@linaro.org> wrote:

>
> Hi Evgeny,
>
> Minor comments:
> - the patch title should end with [PRnnnnn, ...] (choose the most
> relevant bug number)
> - ChangeLog should mention every bug with PR component/nnnnn
> so that the bugzilla hooks will notice the commit.
> See
> https://gcc.gn/
> u.org%2Fcontribute.html%23patches&data=05%7C02%7CEvgeny.Karpov%40m
> icrosoft.com%7C5a0dc959feac45f679db08dc968bdafc%7C72f988bf86f141af9
> 1ab2d7cd011db47%7C1%7C0%7C638550774683835608%7CUnknown%7CT
> WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6Mn0%3D%7C0%7C%7C%7C&sdata=v5rvSCIFzfLI9yyVt1jSwGsCPaaQNOZ
> n5J3RoEdJGRw%3D&reserved=0
>
> (but I can do it for you before pushing the patch)
>
> Thanks,
>
> Christophe
>

Thanks Christophe, I will update the patch with required references.

Regards,
Evgeny


More information about the Gcc-patches mailing list