[PATCH] [libstdc++] [testsuite] defer to check_vect_support* [PR115454]

[Jonathan Wakely]

On Thu, 27 Jun 2024, 01:53 Matthias Kretz, <m.kretz@gsi.de> wrote:

> Ah, thank you. I didn't realize that there's a default for dg-do. I
> probably
> knew it back when I added check_vect_support_and_set_flags...
>
> OK for all branches from my side.
>

Yup, ok to push then, thanks.



> -Matthias
>
> On Wednesday, 26 June 2024 04:45:28 CDT Alexandre Oliva wrote:
> > The newly-added testcase overrides the default dg-do action set by
> > check_vect_support_and_set_flags (in libstdc++-dg/conformance.exp), so
> > it attempts to run the test even if runtime vector support is not
> > available.
> >
> > Remove the explicit dg-do directive, so that the default is honored,
> > and the test is run if vector support is found, and only compiled
> > otherwise.
> >
> > Tested so far with gcc-13 on ppc64-vx7r2, targeting vector-less
> > hardware, where it cured the observed regression.  Regstrapping on
> > x86_64- and ppc64el-linux-gnu just to be sure.  Ok to install?
> >
> >
> > for  libstdc++-v3/ChangeLog
> >
> >       PR libstdc++/115454
> >       * testsuite/experimental/simd/pr115454_find_last_set.cc: Defer
> >       to check_vect_support_and_set_flags's default dg-do action.
> > ---
> >  .../experimental/simd/pr115454_find_last_set.cc    |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git
> > a/libstdc++-v3/testsuite/experimental/simd/pr115454_find_last_set.cc
> > b/libstdc++-v3/testsuite/experimental/simd/pr115454_find_last_set.cc
> index
> > 25a713b4e948c..4ade8601f272f 100644
> > --- a/libstdc++-v3/testsuite/experimental/simd/pr115454_find_last_set.cc
> > +++ b/libstdc++-v3/testsuite/experimental/simd/pr115454_find_last_set.cc
> > @@ -1,5 +1,4 @@
> >  // { dg-options "-std=gnu++17" }
> > -// { dg-do run { target *-*-* } }
> >  // { dg-require-effective-target c++17 }
> >  // { dg-additional-options "-march=x86-64-v4" { target avx512f_runtime
> } }
> >  // { dg-require-cmath "" }
>
>
> --
> ──────────────────────────────┬────────────────────────────────────────────
>  Dr. Matthias Kretz           │ SDE — Software Development for Experiments
>  Senior Software Engineer,    │ 📞 +49 6159 713084
>  SIMD Expert,                 │ 📧 m.kretz@gsi.de     floss.social/@mkretz
>  ISO C++ Numerics Chair       │ 🔗 mattkretz.github.io
> ──────────────────────────────┴────────────────────────────────────────────
>
> GSI Helmholtzzentrum für Schwerionenforschung GmbH
> Planckstraße 1, 64291 Darmstadt, Germany, www.gsi.de
>
> Commercial Register / Handelsregister: Amtsgericht Darmstadt, HRB 1528
> Managing Directors / Geschäftsführung:
> Professor Dr. Paolo Giubellino, Dr. Katharina Stummeyer, Jörg Blaurock
> Chairman of the GSI Supervisory Board / Vorsitzender des GSI-Aufsichtsrats:
> Ministerialdirigent Dr. Volkmar Dietz
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20240627/5ce583a9/attachment.htm>