[PATCH] AIX Build failure with default -std=gnu23.

[David Edelsohn]

On Fri, Dec 6, 2024 at 2:17 PM Ian Lance Taylor <ian@airs.com> wrote:

> David Edelsohn <dje.gcc@gmail.com> writes:
>
> > On Fri, Dec 6, 2024 at 12:25 PM Rainer Orth <ro@cebitec.uni-bielefeld.de
> >
> > wrote:
> >
> >> Hi David,
> >>
> >> > No objection from me, but Ian is the maintainer of libiberty, so I'll
> >> defer
> >> > to him, especially about style and overall software engineering.
> >> >
> >> > The C23 change presumably will break on Alpha OSF/1 as well.  Does GCC
> >> > still support OSF/1?  It might be preferred to delete the block
> entirely
> >> > instead of #ifndef _AIX.
> >>
> >> GCC 4.7 was the last release to support Tru64 UNIX (ex-OSF/1).  However,
> >> libiberty is also used outside of the toolchain, so that may affect the
> >> decision.
> >>
> >> However, IMO the Tru64 UNIX support can go for good now.
> >>
> >
> > Hi, Rainer
> >
> > Thanks for taking a look and commenting.
> >
> > It seems we both agree that it would be better to remove the entire block
> > defining _NO_PROTO because both of the systems are no longer supported.
> >
> > I'll give Ian the opportunity to comment.
>
> Looks good to me.  Thanks.
>
> Ian
>

Sangamesh,

Can you respin and test a revised patch that removes the conditional
_NO_PROTO definition instead of adding #ifndef _AIX?  I think that is what
Rainer and I would prefer because neither of the OSes is supported and we
don't need a fragile work-around.

Thanks, David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20241206/af84b3ce/attachment.htm>