[PATCH 3/3] contrib: Fix nonportable shell syntax in "test" and "[" commands [PR105831]

Jakub Jelinek jakub@redhat.com
Thu May 18 13:00:43 GMT 2023


On Thu, May 18, 2023 at 01:56:47PM +0100, Jonathan Wakely via Gcc-patches wrote:
> POSIX sh does not support the == for string comparisons, use = instead.
> 
> These contrib scripts all use a bash shebang so == does work, but
> there's no reason they can't just use the more portable form anyway.
> 
> 	PR bootstrap/105831
> 
> contrib/ChangeLog:
> 
> 	* bench-stringop: Use = operator instead of ==.
> 	* repro_fail: Likewise.
> 
> contrib/reghunt/ChangeLog:
> 
> 	* bin/reg-hunt: Use = operator instead of ==.

LGTM.

	Jakub



More information about the Gcc-patches mailing list