[PATCH] i386: Honour -mdirect-extern-access when calling __fentry__

Uros Bizjak ubizjak@gmail.com
Fri May 12 17:05:06 GMT 2023


On Fri, May 12, 2023 at 4:07 PM Ard Biesheuvel <ardb@kernel.org> wrote:

> > > > > Note that the GOT reference in question is in fact a data reference: we
> > > > > explicitly load the address of __fentry__ from the GOT, which amounts to
> > > > > eager binding, rather than emitting a PLT call that could bind eagerly,
> > > > > lazily or directly at link time.
> > > > >
> > > > > gcc/ChangeLog:
> > > > >
> > > > >         * config/i386/i386.cc (x86_function_profiler): Take
> > > > >           ix86_direct_extern_access into account when generating calls
> > > > >           to __fentry__()
> > > >
> > > > HJ, is the patch OK with you?
> > >
> > > LGTM.
> >
> > OK then.
> >
>
> Thanks all. Is anything expected of me at this point?

Do you have write access to the repository? If not I can commit the
patch for you, but you should state this [1] in your patch submission.

[1] https://gcc.gnu.org/contribute.html

Uros.


More information about the Gcc-patches mailing list