[Patch] gcn/t-omp-device: Add 'amdgcn' as 'arch' [PR105602]

Tobias Burnus tobias@codesourcery.com
Tue May 17 12:45:09 GMT 2022


Hi Jakub, hi Andrew,

On 17.05.22 10:01, Jakub Jelinek wrote:
> But the above patch only implements it partially.
> What is in omp-device-properties-* is for the sake of the host compiler,
> [...]
> You need to also change gcc/config/gcn/gcn.cc (gcn_omp_device_kind_arch_isa)
> case omp_device_arch: handling so that it accepts both "gcn" and "amdgcn"
> equally.

Done with the attached patch, which I intent to commit after the lunch break,
unless there are further comments.

* * *

Additionally, I am considering to document the permitted values → second patch.
The idea is to later add more device-specific information, separately for gcn
and nvptx like simd/teams/threads handling or similar information (additional
envvar, where it makes sense etc.), which is currently spread over several
slides, wikipages, mouth-to-mouth information etc.

Thoughts regarding the second patch?

Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t-omp-device-amdgcn-v2.diff
Type: text/x-patch
Size: 1303 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20220517/af7a7400/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: context-selector-texi.diff
Type: text/x-patch
Size: 2160 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20220517/af7a7400/attachment-0001.bin>


More information about the Gcc-patches mailing list