[PATCH][libgomp, testsuite] Scale down some OpenACC test-cases

Tom de Vries tdevries@suse.de
Fri Mar 25 12:54:37 GMT 2022


On 3/25/22 13:35, Thomas Schwinge wrote:
> Hi!
> 
> On 2022-03-25T13:08:52+0100, Tom de Vries <tdevries@suse.de> wrote:
>> On 3/25/22 11:04, Tobias Burnus wrote:
>>> On 25.03.22 10:27, Jakub Jelinek via Gcc-patches wrote:
>>>> On Fri, Mar 25, 2022 at 10:18:49AM +0100, Tom de Vries wrote:
>>>>> [...]
>>>>> Fix this by scaling down the failing test-cases.
>>>>> Tested on x86_64-linux with nvptx accelerator.
>>>>> [...]
>>>> Will defer to Thomas, as it is a purely OpenACC change.
>>>>
>>>> One way to do it is
>>>> /* { dg-additional-options "-DEXPENSIVE" { target run_expensive_tests
>>>> } } */
>>>> and using
>>>> #ifdef EXPENSIVE
>>>> [...]
>>>>
>>>> For the Fortran test it would mean .F90 extension though...
>>>
>>> Alternative, use the "-cpp" flag in 'dg-additional-options', which also
>>> enables the C-pre-processor pre-processing in gfortran.
>>
>> Ack, updated patch accordingly.
> 
> Not sure if this additional "complexity" is really necessary here: as far
> as I can tell, there's no actual rationale behind the original number of
> iterations, so it seems fine to unconditionally scale them down.  I'd
> thus move forward with your original patch -- but won't object the
> 'run_expensive_tests' variant either; the latter is already used in a
> handful of other libgomp test cases.
> 

Ack, committed the GCC_TEST_RUN_EXPENSIVE variant.

Thanks,
- Tom


More information about the Gcc-patches mailing list