[PATCH] AVX512FP16: Fix masm=intel output for vfc?(madd|mul)csh [PR 104977]

Hongtao Liu crazylht@gmail.com
Mon Mar 21 01:01:24 GMT 2022


On Sat, Mar 19, 2022 at 8:06 AM Hongyu Wang via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> This patch fixes typo in subst for scalar complex mask_round operand.
>
> Bootstraped/regtested on x86_64-pc-linux-gnu{-m32,} and sde.
>
> Ok for master?
>
Ok.
> gcc/ChangeLog:
>
>         PR target/104977
>         * config/i386/sse.md
>         (avx512fp16_fma<complexopname>sh_v8hf<mask_scalarcz_name><round_scalarcz_name>):
>         Correct round operand for intel dialect.
>
> gcc/testsuite/ChangeLog:
>
>         PR target/104977
>         * gcc.target/i386/pr104977.c: New test.
> ---
>  gcc/config/i386/sse.md                   |  2 +-
>  gcc/testsuite/gcc.target/i386/pr104977.c | 13 +++++++++++++
>  2 files changed, 14 insertions(+), 1 deletion(-)
>  create mode 100644 gcc/testsuite/gcc.target/i386/pr104977.c
>
> diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> index ed98120be59..21bf3c55c95 100644
> --- a/gcc/config/i386/sse.md
> +++ b/gcc/config/i386/sse.md
> @@ -6723,7 +6723,7 @@ (define_insn "avx512fp16_fma_<complexopname>sh_v8hf<mask_scalarcz_name><round_sc
>           (match_dup 2)
>           (const_int 3)))]
>    "TARGET_AVX512FP16"
> -  "v<complexopname>sh\t{<round_scalarcz_mask_op4>%2, %1, %0<mask_scalarcz_operand4>|%0<mask_scalarcz_operand4>, %1, %2<round_scalarcz_maskcz_mask_op4>}"
> +  "v<complexopname>sh\t{<round_scalarcz_mask_op4>%2, %1, %0<mask_scalarcz_operand4>|%0<mask_scalarcz_operand4>, %1, %2<round_scalarcz_mask_op4>}"
>    [(set_attr "type" "ssemuladd")
>     (set_attr "mode" "V8HF")])
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr104977.c b/gcc/testsuite/gcc.target/i386/pr104977.c
> new file mode 100644
> index 00000000000..9faa4db3b0d
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr104977.c
> @@ -0,0 +1,13 @@
> +/* PR target/104977 */
> +/* { dg-do assemble } */
> +/* { dg-options "-O2 -mavx512fp16 -masm=intel" } */
> +/* { dg-require-effective-target avx512fp16 } */
> +/* { dg-require-effective-target masm_intel } */
> +
> +#include<immintrin.h>
> +
> +__m128h
> +foo (__m128h a, __m128h b, __m128h c, __mmask8 m)
> +{
> +  return _mm_fcmadd_round_sch (a, b, c, 8);
> +}
> --
> 2.18.1
>


-- 
BR,
Hongtao


More information about the Gcc-patches mailing list