[PING PATCH 2/3] rs6000: Move g++.dg powerpc PR tests to g++.target

Paul A. Clarke pc@us.ibm.com
Tue Mar 8 20:03:04 GMT 2022


Gentle ping. I am grateful for the initial review, but seek closure on the
final couple of discussion items. Thanks!

PC

On Tue, Feb 22, 2022 at 07:56:40PM -0600, Paul A. Clarke via Gcc-patches wrote:
> On Tue, Feb 22, 2022 at 06:41:45PM -0600, Segher Boessenkool wrote:
> > On Mon, Feb 21, 2022 at 03:17:46PM -0600, Paul A. Clarke wrote:
> > > Also adjust DejaGnu directives, as specifically requiring "powerpc*-*-*" is no
> > > longer required.
> > > 
> > > 2021-02-21  Paul A. Clarke  <pc@us.ibm.com>
> > > 
> > > gcc/testsuite
> > > 	* g++.dg/pr65240.h: Move to g++.target/powerpc.
> > > 	* g++.dg/pr93974.C: Likewise.
> > > 	* g++.dg/pr65240-1.C: Move to g++.target/powerpc, adjust dg directives.
> > > 	* g++.dg/pr65240-2.C: Likewise.
> > > 	* g++.dg/pr65240-3.C: Likewise.
> > > 	* g++.dg/pr65240-4.C: Likewise.
> > > 	* g++.dg/pr65242.C: Likewise.
> > > 	* g++.dg/pr67211.C: Likewise.
> > > 	* g++.dg/pr69667.C: Likewise.
> > > 	* g++.dg/pr71294.C: Likewise.
> > > 	* g++.dg/pr84264.C: Likewise.
> > > 	* g++.dg/pr84279.C: Likewise.
> > > 	* g++.dg/pr85657.C: Likewise.
> > 
> > Okay for trunk.  Thanks!
> 
> Thanks for the review! More below...
> 
> > That said...
> > 
> > > -/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
> > > -/* { dg-skip-if "" { powerpc*-*-darwin* } } */
> > > +/* { dg-do compile { target lp64 } } */
> > > +/* { dg-skip-if "" { *-*-darwin* } } */
> > 
> > That skip-if is most likely cargo cult, and it's not clear why lp64
> > would be needed either (there is no comment what it is needed for, for
> > example).
> 
> I can't speak to darwin, nor have an easy way of testing on it.
> 
> As for lp64, these tests fail on -m32 with:
>   cc1plus: error: '-mcmodel' not supported in this configuration
> - g++.dg/pr65240-1.C
> - g++.dg/pr65240-2.C
> - g++.dg/pr65240-3.C
> 
> '-mcmodel' is in the dg-options line for the above tests.
> 
> The rest PASSed.  Shall I remove the 'lp64' restriction for those that PASS?
> 
> > > +++ b/gcc/testsuite/g++.target/powerpc/pr85657.C
> > > @@ -1,4 +1,4 @@
> > > -// { dg-do compile { target { powerpc*-*-linux* } } }
> > > +// { dg-do compile { target { *-*-linux* } } }
> > 
> > A comment here would help as well.  All of that is pre-existing of
> > course.
> 
> I'm not sure what such a comment would say. I suspect it was a testing issue
> (only tested on Linux), but I have similar limitations, so I'm also reluctant
> to enable the test for what would be untested (by me) platforms.
> 
> PC


More information about the Gcc-patches mailing list