[PATCH, Fortran] Fix testcases that violate C838, + revealed ICE

[Tobias Burnus]

On 20.09.21 06:02, Sandra Loosemore wrote:
> This patch fixes 3 testcases that violate F2018 C838 by passing an
> assumed-rank argument to a procedure via an assumed-sized dummy, by
> wrapping the call in a SELECT RANK construct.  But wait, there's more!
> This triggered an ICE due to a null pointer dereference in the code
> that handles the associated variable in the SELECT RANK.  I fixed that
> by copying the idiom used in other places for
> GFC_DECL_SAVED_DESCRIPTOR, so now all the tests pass again.
>
> Is this OK to commit?

LGTM – as mentioned in the other patch, please commit this patch first
to avoid intermittent testsuite fails.

Tobias

> I confess I'm not certain whether adding the SELECT RANK causes the
> testcases now to do something different from what they were originally
> trying to test, but they never should have worked as originally
> written anyway.  We were just not previously diagnosing the C838
> violations without the other patch I just posted to do that.
>
> -Sandra
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955