[PATCH] MAINTAINERS: Clarify the policy WRT the Write After Approval list
Maciej W. Rozycki
Wed Oct 27 12:32:13 GMT 2021
* MAINTAINERS: Clarify the policy WRT the Write After Approval
On Tue, 26 Oct 2021, Jeff Law wrote:
> > > It seems like there's been hardly any discussion about this matter
> > > around
> > > the time this stuff was added with commit bddcac9d1c32 ("[contrib] Add
> > > contrib/maintainers-verify.sh"). What was the actual motivation behind
> > > that change?
> > That was only addition of a script and testcase to verify what has been done
> > in MAINTAINERS since forever.
> > Just look at all the commits to remove redundant entries from Write After
> > Approval, e.g.
> > https://gcc.gnu.org/legacy-ml/gcc-patches/2003-05/msg00366.html
> > All maintainers or reviewers (global or specific) have write after approval
> > rights for areas they don't maintain.
> I went ahead and fixed Maciej's entries in the obvious way.
Thanks. It did not occur to me that we had such a policy in place even
before said commit, and now that I can see it is the case it seems to me
like it has been a recurring problem with people not being aware of it,
and I can hardly imagine anyone running the test suite for a MAINTAINERS
So while I maintain my concerns about the policy itself, how about this
change, so that at least it's written down somewhere other than mailing
list archives only?
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fe56b2f647e..1471f53d30b 100644
@@ -15,6 +15,9 @@ To report problems in GCC, please visit:
+Note: when adding someone to a more specific section please remove any
+corresponding entry from the Write After Approval list.
More information about the Gcc-patches